Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nncf model export bug #1346

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

ashwinvaidya17
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Nov 8, 2022
@harimkang harimkang requested a review from eunwoosh November 8, 2022 08:58
@harimkang
Copy link
Contributor

harimkang commented Nov 8, 2022

@eunwoosh This is a modification of the last code you edited (in #1300), could you take a look?

@eunwoosh
Copy link
Contributor

eunwoosh commented Nov 8, 2022

I changed this code like this to fix HPO bug in anomaly task which is occurred when saving initial weight of anomaly model before training.
please refer https://github.com/openvinotoolkit/training_extensions/pull/1300
So, could you fix the bug by the other method?

@goodsong81
Copy link
Contributor

This will break HPO in Geti side.
BTW, could you retarget to releases/v0.3.1-geti1.0.0?
RC2 already has been merged.

@ashwinvaidya17
Copy link
Contributor Author

Okay, I'll update the other method and retarget the branch

@ashwinvaidya17 ashwinvaidya17 changed the base branch from releases/v0.3.1-geti1.0.0-rc2 to releases/v0.3.1-geti1.0.0 November 8, 2022 09:34
@goodsong81
Copy link
Contributor

LGTM, but could you run local CLI test to verify if this change works for anomaly?
(Screen also might be helpful)

@ashwinvaidya17
Copy link
Contributor Author

Here are the results for the classification tests
image

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashwinvaidya17 thanks for the effort and quick find!

@goodsong81
Copy link
Contributor

Thank you for quick fix. Could you let us know the bug ticket, if any?

@samet-akcay
Copy link
Contributor

Thank you for quick fix. Could you let us know the bug ticket, if any?

@goodsong81, as far as I'm concerned, there is no ticket for this. It was relatively a new issue spotted yesterday. @chuneuny-emily can you confirm this?

@chuneuny-emily
Copy link
Contributor

Thank you for quick fix. Could you let us know the bug ticket, if any?

@goodsong81, as far as I'm concerned, there is no ticket for this. It was relatively a new issue spotted yesterday. @chuneuny-emily can you confirm this?

Yes. There is no bug ticket yet. It was found in OTE component validation results I was run yesterday. Thank you for quick fix. Please merge it.

@goodsong81 goodsong81 merged commit 90ceb7c into releases/v0.3.1-geti1.0.0 Nov 8, 2022
@goodsong81 goodsong81 deleted the ashwin/fix_nncf_export branch November 8, 2022 23:34
@goodsong81
Copy link
Contributor

Merged. This could be included RC3, which could be FRC I hope :)

eunwoosh added a commit that referenced this pull request Nov 9, 2022
goodsong81 added a commit that referenced this pull request Nov 11, 2022
* anomaly save_model bugfix (#1300)

* upgrade networkx module version (#1303)

* Forward CVS-94422 size bug fix PR to release branch (#1326)

* Valid POT configs for small HRNet models (#1317)

* [Release branch] Disable NNCF optimization for FP16 models  (#1319)

* [RELEASE] CVS-95549 - Hierarchical classification training failed without obvious reason (#1329)

* Fix h-label: per-group softmax (#1332)

* Fix dataset length bug in mpa task (#1338)

* Fix drop_last key issue for det/set (#1340)

* Hot-fix for OV inference for iseg output (#1345)

* Fix nncf model export bug (#1346)

Signed-off-by: Songki Choi <[email protected]>
Co-authored-by: Eunwoo Shin <[email protected]>
Co-authored-by: Yunchu Lee <[email protected]>
Co-authored-by: Eugene Liu <[email protected]>
Co-authored-by: Daniil Lyakhov <[email protected]>
Co-authored-by: Jihwan Eom <[email protected]>
Co-authored-by: Vladisalv Sovrasov <[email protected]>
Co-authored-by: Harim Kang <[email protected]>
Co-authored-by: Ashwin Vaidya <[email protected]>
Co-authored-by: Ashwin Vaidya <[email protected]>
goodsong81 added a commit that referenced this pull request Dec 28, 2022
* Add tiling module (#1200)

* Update submodule branch (#1222)

* Enhance training schedule for multi-label classification (#1212)

* [CVS-88098] Remove initialize from export functions (#1226)

* Train graph added (#1211)

* Add @attrs decorator for base configs (#1229)

* Pretrained weight download error in MobilenetV3-large-1 of deep-object-reid in SC (#1233)

* [Anomaly Task] Revert hpo template (#1230)

* 🐞 [Anomaly Task] Fix progress bar (#1223)

* [CVS-90555] Fix NaN value in classification (#1244)

* update hpo_config.yaml (#1240)

* [CVS-90400, CVS-91015] NNCF pruning supported tweaks (#1248)

* [Anomaly Task] 🐞 Fix inference when model backbone changes (#1242)

* [CVS-91472] Add pruning_supported value (#1263)

* Pruning supported tweaks (#1256)

* [CVS-90400, CVS-91015] NNCF pruning supported tweaks (#1248)

* Revert "[CVS-90400, CVS-91015] NNCF pruning supported tweaks (#1248)" (#1269)

* [OTE-TEST] Disable obsolete test cases (#1220)

* [OTE-TEST] hot-fix for MPA performance tests (#1273)

* [Anomaly Task] ✨ Upgrade anomalib (#1243)

* Expose early stopping hyper-parameters for all tasks (#1241)

* Resolve pre-commit issues (#1272)

* Remove LazyEarlyStopHook in model_multilabel.py (#1281)

* Removed xfail (#1239)

* Implement IB loss for incremental learning in multi-class classification (#1289)

* Edit num_workers and change MPA repo as a latest (#1314)

* fix annotation bug (#1320)

* Valid POT configs for small HRNet models (#1313)

* Disable NNCF optimization for FP16 models (#1312)

* fliter object less than 1 pixel  (#1305)

* Fix some tests (#1322)

* [Develop] Move drop_last into MPA (#1357)

* Apply changes from releases/v0.3.1-geti1.0.0 (#1337)

* anomaly save_model bugfix (#1300)

* upgrade networkx module version (#1303)

* Forward CVS-94422 size bug fix PR to release branch (#1326)

* Valid POT configs for small HRNet models (#1317)

* [Release branch] Disable NNCF optimization for FP16 models  (#1319)

* [RELEASE] CVS-95549 - Hierarchical classification training failed without obvious reason (#1329)

* Fix h-label: per-group softmax (#1332)

* Fix dataset length bug in mpa task (#1338)

* Fix drop_last key issue for det/set (#1340)

* Hot-fix for OV inference for iseg output (#1345)

* Fix nncf model export bug (#1346)

* Fixed merge error (#1359)

* Update evaluation iou_thr of ins-seg (#1354)

* fix pre-commit test (#1366)

* Fix dataset item tests (#1360)

* Fix OV Inference issues (tiling tests & detection tests) (#1361)

* fix black & add xfail test cases (#1367)

* Update check_nncf_graph. (#1330)

* [Develop] Hot-fix OV inference issue in rotated detection (#1375)

* [Develop] updated documents (#1383)

* [CVS-94911] Fix difference between train and validation normalization pipeline (#1310)

* Update configs for padim model (#1378)

* updated QUICK_START_GUIDE.md (#1397)

* Change ote threshold of openvino test for cls (#1401)

* Normalize top-1 metrics to [0, 1] (#1394)

* Tiling deployment (#1387)

* Replace current saliency map generation with Recipro-CAM for cls (#1363)

* Class-wise saliency map generation for the detection task (#1402)

* Change submodule to develop (#1410)

* Send full dataset to POT optimization function (#1379) & Convert NaN to num to make visible in geti UI (#1413)

* Add active score evaluation to the classification task

* [release/0.4.0][OTX] Enabling GPU execution for exported code (#1416)

* [OTE][Release][XAI] Detection fix two stage bbox_head error (#1414)

* Update SDK commit for exportable code (#1423)

* HRNet-x and HRNe-18--mod2 configs update (#1419)

* [Release] Enable tiling oriented detection for v0.4.0/geti1.1.0 (#1427)

* [OTE][Releases v0.4.0][XAI] Hot-fix for Detection fix two stage error (#1433)

* Temporary MPA branch while dev->otx merge process

* Update doc & install for dev->otx changes

* Update ote_sdk -> otx.api

* Update ote_cli -> otx.cli

* Update external/mmsegmentation -> otx/algorithms/segmentation

* Align saliency map media instantiation over tasks (#1447)

* Update external/d-o-r -> otx/algorithms/classification

* Update external/mmdetection -> otx/algorithms/detection

* Update external/mpa -> otx/algorithms/*

* Fix CLI test run for better error message

* Numpy constraint for deprecated np.bool error

* Capture stderr only

* Align numpy requirement

* [OTX/Anomaly] Add changes from external to otx (#1452)

* Add changes from external to otx

* Address PR comments

* Update config files + remove backbone from base

* Fix pre-merge checks

* Fix pre-commit issues

* Update exportable code commit

* Fix indent error

* Fix flake8 issue

* Resolve softmax issue w/ FIXME for future work

* Add tiling tests

* Revert MPA branch to otx

Signed-off-by: Songki Choi <[email protected]>
Co-authored-by: Eugene Liu <[email protected]>
Co-authored-by: Ashwin Vaidya <[email protected]>
Co-authored-by: Jaeguk Hyun <[email protected]>
Co-authored-by: Nikita Savelyev <[email protected]>
Co-authored-by: Jihwan Eom <[email protected]>
Co-authored-by: Harim Kang <[email protected]>
Co-authored-by: Soobee Lee <[email protected]>
Co-authored-by: Lee, Soobee <[email protected]>
Co-authored-by: Emily Chun <[email protected]>
Co-authored-by: ljcornel <[email protected]>
Co-authored-by: Eunwoo Shin <[email protected]>
Co-authored-by: dlyakhov <[email protected]>
Co-authored-by: kprokofi <[email protected]>
Co-authored-by: Sungman Cho <[email protected]>
Co-authored-by: Yunchu Lee <[email protected]>
Co-authored-by: Ashwin Vaidya <[email protected]>
Co-authored-by: Alexander Dokuchaev <[email protected]>
Co-authored-by: Vladislav Sovrasov <[email protected]>
Co-authored-by: Evgeny Tsykunov <[email protected]>
Co-authored-by: Galina Zalesskaya <[email protected]>
Co-authored-by: dongkwan-kim <[email protected]>
sungmanc added a commit that referenced this pull request Dec 28, 2022
* make logfile saved in save-model-to directory

* enable train

* make main process train also

* bugfix

* refactor multi gpu training

* make all processs have same output path

* prevent child process from being termated by fokred main process

* refactor multigpu implementation

* refactor multi gpu implementation

* modify argument help sentence

* add multi gpu test code

* align with pre-commit test

* separate multi GPU manager class

* modify train cli argument 'save-logs-to' to 'output-path'

* remove tray excpet during killing child process

* apply output_path to all tasks

* change print to logger

* skip multi gpu test if number of gpu is insufficient

* fix typo

* multi gpu test bugfix

* isort fix

* test case bugfix

* fix typo and change some variable name

* [OTX] Apply changes in develop to feature/otx branch (#1436)

* Add tiling module (#1200)

* Update submodule branch (#1222)

* Enhance training schedule for multi-label classification (#1212)

* [CVS-88098] Remove initialize from export functions (#1226)

* Train graph added (#1211)

* Add @attrs decorator for base configs (#1229)

* Pretrained weight download error in MobilenetV3-large-1 of deep-object-reid in SC (#1233)

* [Anomaly Task] Revert hpo template (#1230)

* 🐞 [Anomaly Task] Fix progress bar (#1223)

* [CVS-90555] Fix NaN value in classification (#1244)

* update hpo_config.yaml (#1240)

* [CVS-90400, CVS-91015] NNCF pruning supported tweaks (#1248)

* [Anomaly Task] 🐞 Fix inference when model backbone changes (#1242)

* [CVS-91472] Add pruning_supported value (#1263)

* Pruning supported tweaks (#1256)

* [CVS-90400, CVS-91015] NNCF pruning supported tweaks (#1248)

* Revert "[CVS-90400, CVS-91015] NNCF pruning supported tweaks (#1248)" (#1269)

* [OTE-TEST] Disable obsolete test cases (#1220)

* [OTE-TEST] hot-fix for MPA performance tests (#1273)

* [Anomaly Task] ✨ Upgrade anomalib (#1243)

* Expose early stopping hyper-parameters for all tasks (#1241)

* Resolve pre-commit issues (#1272)

* Remove LazyEarlyStopHook in model_multilabel.py (#1281)

* Removed xfail (#1239)

* Implement IB loss for incremental learning in multi-class classification (#1289)

* Edit num_workers and change MPA repo as a latest (#1314)

* fix annotation bug (#1320)

* Valid POT configs for small HRNet models (#1313)

* Disable NNCF optimization for FP16 models (#1312)

* fliter object less than 1 pixel  (#1305)

* Fix some tests (#1322)

* [Develop] Move drop_last into MPA (#1357)

* Apply changes from releases/v0.3.1-geti1.0.0 (#1337)

* anomaly save_model bugfix (#1300)

* upgrade networkx module version (#1303)

* Forward CVS-94422 size bug fix PR to release branch (#1326)

* Valid POT configs for small HRNet models (#1317)

* [Release branch] Disable NNCF optimization for FP16 models  (#1319)

* [RELEASE] CVS-95549 - Hierarchical classification training failed without obvious reason (#1329)

* Fix h-label: per-group softmax (#1332)

* Fix dataset length bug in mpa task (#1338)

* Fix drop_last key issue for det/set (#1340)

* Hot-fix for OV inference for iseg output (#1345)

* Fix nncf model export bug (#1346)

* Fixed merge error (#1359)

* Update evaluation iou_thr of ins-seg (#1354)

* fix pre-commit test (#1366)

* Fix dataset item tests (#1360)

* Fix OV Inference issues (tiling tests & detection tests) (#1361)

* fix black & add xfail test cases (#1367)

* Update check_nncf_graph. (#1330)

* [Develop] Hot-fix OV inference issue in rotated detection (#1375)

* [Develop] updated documents (#1383)

* [CVS-94911] Fix difference between train and validation normalization pipeline (#1310)

* Update configs for padim model (#1378)

* updated QUICK_START_GUIDE.md (#1397)

* Change ote threshold of openvino test for cls (#1401)

* Normalize top-1 metrics to [0, 1] (#1394)

* Tiling deployment (#1387)

* Replace current saliency map generation with Recipro-CAM for cls (#1363)

* Class-wise saliency map generation for the detection task (#1402)

* Change submodule to develop (#1410)

* Send full dataset to POT optimization function (#1379) & Convert NaN to num to make visible in geti UI (#1413)

* Add active score evaluation to the classification task

* [release/0.4.0][OTX] Enabling GPU execution for exported code (#1416)

* [OTE][Release][XAI] Detection fix two stage bbox_head error (#1414)

* Update SDK commit for exportable code (#1423)

* HRNet-x and HRNe-18--mod2 configs update (#1419)

* [Release] Enable tiling oriented detection for v0.4.0/geti1.1.0 (#1427)

* [OTE][Releases v0.4.0][XAI] Hot-fix for Detection fix two stage error (#1433)

* Temporary MPA branch while dev->otx merge process

* Update doc & install for dev->otx changes

* Update ote_sdk -> otx.api

* Update ote_cli -> otx.cli

* Update external/mmsegmentation -> otx/algorithms/segmentation

* Align saliency map media instantiation over tasks (#1447)

* Update external/d-o-r -> otx/algorithms/classification

* Update external/mmdetection -> otx/algorithms/detection

* Update external/mpa -> otx/algorithms/*

* Fix CLI test run for better error message

* Numpy constraint for deprecated np.bool error

* Capture stderr only

* Align numpy requirement

* [OTX/Anomaly] Add changes from external to otx (#1452)

* Add changes from external to otx

* Address PR comments

* Update config files + remove backbone from base

* Fix pre-merge checks

* Fix pre-commit issues

* Update exportable code commit

* Fix indent error

* Fix flake8 issue

* Resolve softmax issue w/ FIXME for future work

* Add tiling tests

* Revert MPA branch to otx

Signed-off-by: Songki Choi <[email protected]>
Co-authored-by: Eugene Liu <[email protected]>
Co-authored-by: Ashwin Vaidya <[email protected]>
Co-authored-by: Jaeguk Hyun <[email protected]>
Co-authored-by: Nikita Savelyev <[email protected]>
Co-authored-by: Jihwan Eom <[email protected]>
Co-authored-by: Harim Kang <[email protected]>
Co-authored-by: Soobee Lee <[email protected]>
Co-authored-by: Lee, Soobee <[email protected]>
Co-authored-by: Emily Chun <[email protected]>
Co-authored-by: ljcornel <[email protected]>
Co-authored-by: Eunwoo Shin <[email protected]>
Co-authored-by: dlyakhov <[email protected]>
Co-authored-by: kprokofi <[email protected]>
Co-authored-by: Sungman Cho <[email protected]>
Co-authored-by: Yunchu Lee <[email protected]>
Co-authored-by: Ashwin Vaidya <[email protected]>
Co-authored-by: Alexander Dokuchaev <[email protected]>
Co-authored-by: Vladislav Sovrasov <[email protected]>
Co-authored-by: Evgeny Tsykunov <[email protected]>
Co-authored-by: Galina Zalesskaya <[email protected]>
Co-authored-by: dongkwan-kim <[email protected]>

* Apply latest MPA openvinotoolkit/model_preparation_algorithm#105

Signed-off-by: Songki Choi <[email protected]>

Signed-off-by: Songki Choi <[email protected]>
Co-authored-by: eunwoosh <[email protected]>
Co-authored-by: Eugene Liu <[email protected]>
Co-authored-by: Ashwin Vaidya <[email protected]>
Co-authored-by: Jaeguk Hyun <[email protected]>
Co-authored-by: Nikita Savelyev <[email protected]>
Co-authored-by: Jihwan Eom <[email protected]>
Co-authored-by: Harim Kang <[email protected]>
Co-authored-by: Soobee Lee <[email protected]>
Co-authored-by: Lee, Soobee <[email protected]>
Co-authored-by: Emily Chun <[email protected]>
Co-authored-by: ljcornel <[email protected]>
Co-authored-by: dlyakhov <[email protected]>
Co-authored-by: kprokofi <[email protected]>
Co-authored-by: Sungman Cho <[email protected]>
Co-authored-by: Yunchu Lee <[email protected]>
Co-authored-by: Ashwin Vaidya <[email protected]>
Co-authored-by: Alexander Dokuchaev <[email protected]>
Co-authored-by: Vladislav Sovrasov <[email protected]>
Co-authored-by: Evgeny Tsykunov <[email protected]>
Co-authored-by: Galina Zalesskaya <[email protected]>
Co-authored-by: dongkwan-kim <[email protected]>
sungmanc added a commit that referenced this pull request Dec 29, 2022
* make logfile saved in save-model-to directory

* enable train

* make main process train also

* bugfix

* refactor multi gpu training

* make all processs have same output path

* prevent child process from being termated by fokred main process

* refactor multigpu implementation

* refactor multi gpu implementation

* modify argument help sentence

* add multi gpu test code

* align with pre-commit test

* separate multi GPU manager class

* modify train cli argument 'save-logs-to' to 'output-path'

* remove tray excpet during killing child process

* apply output_path to all tasks

* change print to logger

* skip multi gpu test if number of gpu is insufficient

* fix typo

* multi gpu test bugfix

* isort fix

* test case bugfix

* fix typo and change some variable name

* [OTX] Apply changes in develop to feature/otx branch (#1436)

* Add tiling module (#1200)

* Update submodule branch (#1222)

* Enhance training schedule for multi-label classification (#1212)

* [CVS-88098] Remove initialize from export functions (#1226)

* Train graph added (#1211)

* Add @attrs decorator for base configs (#1229)

* Pretrained weight download error in MobilenetV3-large-1 of deep-object-reid in SC (#1233)

* [Anomaly Task] Revert hpo template (#1230)

* 🐞 [Anomaly Task] Fix progress bar (#1223)

* [CVS-90555] Fix NaN value in classification (#1244)

* update hpo_config.yaml (#1240)

* [CVS-90400, CVS-91015] NNCF pruning supported tweaks (#1248)

* [Anomaly Task] 🐞 Fix inference when model backbone changes (#1242)

* [CVS-91472] Add pruning_supported value (#1263)

* Pruning supported tweaks (#1256)

* [CVS-90400, CVS-91015] NNCF pruning supported tweaks (#1248)

* Revert "[CVS-90400, CVS-91015] NNCF pruning supported tweaks (#1248)" (#1269)

* [OTE-TEST] Disable obsolete test cases (#1220)

* [OTE-TEST] hot-fix for MPA performance tests (#1273)

* [Anomaly Task] ✨ Upgrade anomalib (#1243)

* Expose early stopping hyper-parameters for all tasks (#1241)

* Resolve pre-commit issues (#1272)

* Remove LazyEarlyStopHook in model_multilabel.py (#1281)

* Removed xfail (#1239)

* Implement IB loss for incremental learning in multi-class classification (#1289)

* Edit num_workers and change MPA repo as a latest (#1314)

* fix annotation bug (#1320)

* Valid POT configs for small HRNet models (#1313)

* Disable NNCF optimization for FP16 models (#1312)

* fliter object less than 1 pixel  (#1305)

* Fix some tests (#1322)

* [Develop] Move drop_last into MPA (#1357)

* Apply changes from releases/v0.3.1-geti1.0.0 (#1337)

* anomaly save_model bugfix (#1300)

* upgrade networkx module version (#1303)

* Forward CVS-94422 size bug fix PR to release branch (#1326)

* Valid POT configs for small HRNet models (#1317)

* [Release branch] Disable NNCF optimization for FP16 models  (#1319)

* [RELEASE] CVS-95549 - Hierarchical classification training failed without obvious reason (#1329)

* Fix h-label: per-group softmax (#1332)

* Fix dataset length bug in mpa task (#1338)

* Fix drop_last key issue for det/set (#1340)

* Hot-fix for OV inference for iseg output (#1345)

* Fix nncf model export bug (#1346)

* Fixed merge error (#1359)

* Update evaluation iou_thr of ins-seg (#1354)

* fix pre-commit test (#1366)

* Fix dataset item tests (#1360)

* Fix OV Inference issues (tiling tests & detection tests) (#1361)

* fix black & add xfail test cases (#1367)

* Update check_nncf_graph. (#1330)

* [Develop] Hot-fix OV inference issue in rotated detection (#1375)

* [Develop] updated documents (#1383)

* [CVS-94911] Fix difference between train and validation normalization pipeline (#1310)

* Update configs for padim model (#1378)

* updated QUICK_START_GUIDE.md (#1397)

* Change ote threshold of openvino test for cls (#1401)

* Normalize top-1 metrics to [0, 1] (#1394)

* Tiling deployment (#1387)

* Replace current saliency map generation with Recipro-CAM for cls (#1363)

* Class-wise saliency map generation for the detection task (#1402)

* Change submodule to develop (#1410)

* Send full dataset to POT optimization function (#1379) & Convert NaN to num to make visible in geti UI (#1413)

* Add active score evaluation to the classification task

* [release/0.4.0][OTX] Enabling GPU execution for exported code (#1416)

* [OTE][Release][XAI] Detection fix two stage bbox_head error (#1414)

* Update SDK commit for exportable code (#1423)

* HRNet-x and HRNe-18--mod2 configs update (#1419)

* [Release] Enable tiling oriented detection for v0.4.0/geti1.1.0 (#1427)

* [OTE][Releases v0.4.0][XAI] Hot-fix for Detection fix two stage error (#1433)

* Temporary MPA branch while dev->otx merge process

* Update doc & install for dev->otx changes

* Update ote_sdk -> otx.api

* Update ote_cli -> otx.cli

* Update external/mmsegmentation -> otx/algorithms/segmentation

* Align saliency map media instantiation over tasks (#1447)

* Update external/d-o-r -> otx/algorithms/classification

* Update external/mmdetection -> otx/algorithms/detection

* Update external/mpa -> otx/algorithms/*

* Fix CLI test run for better error message

* Numpy constraint for deprecated np.bool error

* Capture stderr only

* Align numpy requirement

* [OTX/Anomaly] Add changes from external to otx (#1452)

* Add changes from external to otx

* Address PR comments

* Update config files + remove backbone from base

* Fix pre-merge checks

* Fix pre-commit issues

* Update exportable code commit

* Fix indent error

* Fix flake8 issue

* Resolve softmax issue w/ FIXME for future work

* Add tiling tests

* Revert MPA branch to otx

Signed-off-by: Songki Choi <[email protected]>
Co-authored-by: Eugene Liu <[email protected]>
Co-authored-by: Ashwin Vaidya <[email protected]>
Co-authored-by: Jaeguk Hyun <[email protected]>
Co-authored-by: Nikita Savelyev <[email protected]>
Co-authored-by: Jihwan Eom <[email protected]>
Co-authored-by: Harim Kang <[email protected]>
Co-authored-by: Soobee Lee <[email protected]>
Co-authored-by: Lee, Soobee <[email protected]>
Co-authored-by: Emily Chun <[email protected]>
Co-authored-by: ljcornel <[email protected]>
Co-authored-by: Eunwoo Shin <[email protected]>
Co-authored-by: dlyakhov <[email protected]>
Co-authored-by: kprokofi <[email protected]>
Co-authored-by: Sungman Cho <[email protected]>
Co-authored-by: Yunchu Lee <[email protected]>
Co-authored-by: Ashwin Vaidya <[email protected]>
Co-authored-by: Alexander Dokuchaev <[email protected]>
Co-authored-by: Vladislav Sovrasov <[email protected]>
Co-authored-by: Evgeny Tsykunov <[email protected]>
Co-authored-by: Galina Zalesskaya <[email protected]>
Co-authored-by: dongkwan-kim <[email protected]>

* Apply latest MPA openvinotoolkit/model_preparation_algorithm#105

Signed-off-by: Songki Choi <[email protected]>

Signed-off-by: Songki Choi <[email protected]>
Co-authored-by: eunwoosh <[email protected]>
Co-authored-by: Eugene Liu <[email protected]>
Co-authored-by: Ashwin Vaidya <[email protected]>
Co-authored-by: Jaeguk Hyun <[email protected]>
Co-authored-by: Nikita Savelyev <[email protected]>
Co-authored-by: Jihwan Eom <[email protected]>
Co-authored-by: Harim Kang <[email protected]>
Co-authored-by: Soobee Lee <[email protected]>
Co-authored-by: Lee, Soobee <[email protected]>
Co-authored-by: Emily Chun <[email protected]>
Co-authored-by: ljcornel <[email protected]>
Co-authored-by: dlyakhov <[email protected]>
Co-authored-by: kprokofi <[email protected]>
Co-authored-by: Sungman Cho <[email protected]>
Co-authored-by: Yunchu Lee <[email protected]>
Co-authored-by: Ashwin Vaidya <[email protected]>
Co-authored-by: Alexander Dokuchaev <[email protected]>
Co-authored-by: Vladislav Sovrasov <[email protected]>
Co-authored-by: Evgeny Tsykunov <[email protected]>
Co-authored-by: Galina Zalesskaya <[email protected]>
Co-authored-by: dongkwan-kim <[email protected]>
harimkang added a commit that referenced this pull request Dec 30, 2022
* Initial commit: integrate MPA intothe OTX

* Update Self-SL for seg

* Enable pre-commit tests by ignoring imports, remove useless requirements

* Edit the requirements

* Add dist folder

* fix black

* [OTX] Rebase latest changes for MPA merge (#1468)

* make logfile saved in save-model-to directory

* enable train

* make main process train also

* bugfix

* refactor multi gpu training

* make all processs have same output path

* prevent child process from being termated by fokred main process

* refactor multigpu implementation

* refactor multi gpu implementation

* modify argument help sentence

* add multi gpu test code

* align with pre-commit test

* separate multi GPU manager class

* modify train cli argument 'save-logs-to' to 'output-path'

* remove tray excpet during killing child process

* apply output_path to all tasks

* change print to logger

* skip multi gpu test if number of gpu is insufficient

* fix typo

* multi gpu test bugfix

* isort fix

* test case bugfix

* fix typo and change some variable name

* [OTX] Apply changes in develop to feature/otx branch (#1436)

* Add tiling module (#1200)

* Update submodule branch (#1222)

* Enhance training schedule for multi-label classification (#1212)

* [CVS-88098] Remove initialize from export functions (#1226)

* Train graph added (#1211)

* Add @attrs decorator for base configs (#1229)

* Pretrained weight download error in MobilenetV3-large-1 of deep-object-reid in SC (#1233)

* [Anomaly Task] Revert hpo template (#1230)

* 🐞 [Anomaly Task] Fix progress bar (#1223)

* [CVS-90555] Fix NaN value in classification (#1244)

* update hpo_config.yaml (#1240)

* [CVS-90400, CVS-91015] NNCF pruning supported tweaks (#1248)

* [Anomaly Task] 🐞 Fix inference when model backbone changes (#1242)

* [CVS-91472] Add pruning_supported value (#1263)

* Pruning supported tweaks (#1256)

* [CVS-90400, CVS-91015] NNCF pruning supported tweaks (#1248)

* Revert "[CVS-90400, CVS-91015] NNCF pruning supported tweaks (#1248)" (#1269)

* [OTE-TEST] Disable obsolete test cases (#1220)

* [OTE-TEST] hot-fix for MPA performance tests (#1273)

* [Anomaly Task] ✨ Upgrade anomalib (#1243)

* Expose early stopping hyper-parameters for all tasks (#1241)

* Resolve pre-commit issues (#1272)

* Remove LazyEarlyStopHook in model_multilabel.py (#1281)

* Removed xfail (#1239)

* Implement IB loss for incremental learning in multi-class classification (#1289)

* Edit num_workers and change MPA repo as a latest (#1314)

* fix annotation bug (#1320)

* Valid POT configs for small HRNet models (#1313)

* Disable NNCF optimization for FP16 models (#1312)

* fliter object less than 1 pixel  (#1305)

* Fix some tests (#1322)

* [Develop] Move drop_last into MPA (#1357)

* Apply changes from releases/v0.3.1-geti1.0.0 (#1337)

* anomaly save_model bugfix (#1300)

* upgrade networkx module version (#1303)

* Forward CVS-94422 size bug fix PR to release branch (#1326)

* Valid POT configs for small HRNet models (#1317)

* [Release branch] Disable NNCF optimization for FP16 models  (#1319)

* [RELEASE] CVS-95549 - Hierarchical classification training failed without obvious reason (#1329)

* Fix h-label: per-group softmax (#1332)

* Fix dataset length bug in mpa task (#1338)

* Fix drop_last key issue for det/set (#1340)

* Hot-fix for OV inference for iseg output (#1345)

* Fix nncf model export bug (#1346)

* Fixed merge error (#1359)

* Update evaluation iou_thr of ins-seg (#1354)

* fix pre-commit test (#1366)

* Fix dataset item tests (#1360)

* Fix OV Inference issues (tiling tests & detection tests) (#1361)

* fix black & add xfail test cases (#1367)

* Update check_nncf_graph. (#1330)

* [Develop] Hot-fix OV inference issue in rotated detection (#1375)

* [Develop] updated documents (#1383)

* [CVS-94911] Fix difference between train and validation normalization pipeline (#1310)

* Update configs for padim model (#1378)

* updated QUICK_START_GUIDE.md (#1397)

* Change ote threshold of openvino test for cls (#1401)

* Normalize top-1 metrics to [0, 1] (#1394)

* Tiling deployment (#1387)

* Replace current saliency map generation with Recipro-CAM for cls (#1363)

* Class-wise saliency map generation for the detection task (#1402)

* Change submodule to develop (#1410)

* Send full dataset to POT optimization function (#1379) & Convert NaN to num to make visible in geti UI (#1413)

* Add active score evaluation to the classification task

* [release/0.4.0][OTX] Enabling GPU execution for exported code (#1416)

* [OTE][Release][XAI] Detection fix two stage bbox_head error (#1414)

* Update SDK commit for exportable code (#1423)

* HRNet-x and HRNe-18--mod2 configs update (#1419)

* [Release] Enable tiling oriented detection for v0.4.0/geti1.1.0 (#1427)

* [OTE][Releases v0.4.0][XAI] Hot-fix for Detection fix two stage error (#1433)

* Temporary MPA branch while dev->otx merge process

* Update doc & install for dev->otx changes

* Update ote_sdk -> otx.api

* Update ote_cli -> otx.cli

* Update external/mmsegmentation -> otx/algorithms/segmentation

* Align saliency map media instantiation over tasks (#1447)

* Update external/d-o-r -> otx/algorithms/classification

* Update external/mmdetection -> otx/algorithms/detection

* Update external/mpa -> otx/algorithms/*

* Fix CLI test run for better error message

* Numpy constraint for deprecated np.bool error

* Capture stderr only

* Align numpy requirement

* [OTX/Anomaly] Add changes from external to otx (#1452)

* Add changes from external to otx

* Address PR comments

* Update config files + remove backbone from base

* Fix pre-merge checks

* Fix pre-commit issues

* Update exportable code commit

* Fix indent error

* Fix flake8 issue

* Resolve softmax issue w/ FIXME for future work

* Add tiling tests

* Revert MPA branch to otx

Signed-off-by: Songki Choi <[email protected]>
Co-authored-by: Eugene Liu <[email protected]>
Co-authored-by: Ashwin Vaidya <[email protected]>
Co-authored-by: Jaeguk Hyun <[email protected]>
Co-authored-by: Nikita Savelyev <[email protected]>
Co-authored-by: Jihwan Eom <[email protected]>
Co-authored-by: Harim Kang <[email protected]>
Co-authored-by: Soobee Lee <[email protected]>
Co-authored-by: Lee, Soobee <[email protected]>
Co-authored-by: Emily Chun <[email protected]>
Co-authored-by: ljcornel <[email protected]>
Co-authored-by: Eunwoo Shin <[email protected]>
Co-authored-by: dlyakhov <[email protected]>
Co-authored-by: kprokofi <[email protected]>
Co-authored-by: Sungman Cho <[email protected]>
Co-authored-by: Yunchu Lee <[email protected]>
Co-authored-by: Ashwin Vaidya <[email protected]>
Co-authored-by: Alexander Dokuchaev <[email protected]>
Co-authored-by: Vladislav Sovrasov <[email protected]>
Co-authored-by: Evgeny Tsykunov <[email protected]>
Co-authored-by: Galina Zalesskaya <[email protected]>
Co-authored-by: dongkwan-kim <[email protected]>

* Apply latest MPA openvinotoolkit/model_preparation_algorithm#105

Signed-off-by: Songki Choi <[email protected]>

Signed-off-by: Songki Choi <[email protected]>
Co-authored-by: eunwoosh <[email protected]>
Co-authored-by: Eugene Liu <[email protected]>
Co-authored-by: Ashwin Vaidya <[email protected]>
Co-authored-by: Jaeguk Hyun <[email protected]>
Co-authored-by: Nikita Savelyev <[email protected]>
Co-authored-by: Jihwan Eom <[email protected]>
Co-authored-by: Harim Kang <[email protected]>
Co-authored-by: Soobee Lee <[email protected]>
Co-authored-by: Lee, Soobee <[email protected]>
Co-authored-by: Emily Chun <[email protected]>
Co-authored-by: ljcornel <[email protected]>
Co-authored-by: dlyakhov <[email protected]>
Co-authored-by: kprokofi <[email protected]>
Co-authored-by: Sungman Cho <[email protected]>
Co-authored-by: Yunchu Lee <[email protected]>
Co-authored-by: Ashwin Vaidya <[email protected]>
Co-authored-by: Alexander Dokuchaev <[email protected]>
Co-authored-by: Vladislav Sovrasov <[email protected]>
Co-authored-by: Evgeny Tsykunov <[email protected]>
Co-authored-by: Galina Zalesskaya <[email protected]>
Co-authored-by: dongkwan-kim <[email protected]>

* Resolve some flake8 issues

* Fix semisl trainer import (#1471)

Co-authored-by: Lee, Soobee <[email protected]>

* Fixisort

* Rebase and fix isort

Signed-off-by: Songki Choi <[email protected]>
Co-authored-by: Songki Choi <[email protected]>
Co-authored-by: eunwoosh <[email protected]>
Co-authored-by: Eugene Liu <[email protected]>
Co-authored-by: Ashwin Vaidya <[email protected]>
Co-authored-by: Jaeguk Hyun <[email protected]>
Co-authored-by: Nikita Savelyev <[email protected]>
Co-authored-by: Jihwan Eom <[email protected]>
Co-authored-by: Harim Kang <[email protected]>
Co-authored-by: Soobee Lee <[email protected]>
Co-authored-by: Lee, Soobee <[email protected]>
Co-authored-by: Emily Chun <[email protected]>
Co-authored-by: ljcornel <[email protected]>
Co-authored-by: dlyakhov <[email protected]>
Co-authored-by: kprokofi <[email protected]>
Co-authored-by: Yunchu Lee <[email protected]>
Co-authored-by: Ashwin Vaidya <[email protected]>
Co-authored-by: Alexander Dokuchaev <[email protected]>
Co-authored-by: Vladislav Sovrasov <[email protected]>
Co-authored-by: Evgeny Tsykunov <[email protected]>
Co-authored-by: Galina Zalesskaya <[email protected]>
Co-authored-by: dongkwan-kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants